Skip to content

ci: add gh actions build pipeline with rosdep check#6

Open
rikardoricz wants to merge 3 commits into
mainfrom
ci/actions-build-pipeline
Open

ci: add gh actions build pipeline with rosdep check#6
rikardoricz wants to merge 3 commits into
mainfrom
ci/actions-build-pipeline

Conversation

@rikardoricz

Copy link
Copy Markdown
Member

No description provided.

its only content is a simulation launch, there's no package.xml to remove, COLCON_IGNORE is enough

@kszpieg kszpieg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now as a ad hoc solution it seems to be legit.

Comment thread .github/workflows/ci.yml
Comment on lines +21 to +23
- name: Checkout (with submodules)
uses: actions/checkout@v4
with:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that the newer version is stable now (v6 probably). We can use it here.

Comment thread .github/workflows/ci.yml
Comment on lines +79 to +82
- name: Upload build logs on failure
if: failure()
uses: actions/upload-artifact@v4
with:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that the newer version is stable now (v6 probably). We can use it here.

Comment thread .github/workflows/ci.yml
Comment on lines +97 to +99
- name: Checkout (with submodules)
uses: actions/checkout@v4
with:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that the newer version is stable now (v6 probably). We can use it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants