Fix ImportError#3
Open
vijaravind wants to merge 286 commits into
Open
Conversation
vijaravind
commented
Nov 3, 2013
vijaravind
commented
Collaborator
- Fix ImportError when importing modules.
- Include hashbang and encoding detail in all files.
Owner
|
I don't think that it is a good way to solve the problem. Because IDEs might have problems with function linking. And I think that it is not a big issue right now. It is working with relative paths, so we can leave it like this for a while. We need to finish the functionality at first, then we can think about package structure. |
Fix event KILL_FOCUS bug that was caused when some text fields lost focus. This was because the ID value of the textbox control was used to access individual elements from Matrix (read as list). Since these ID values were assigned using the default wxPython method they were mostly negative values that was causing an `IndexError`. The fix basically assigns custom ID values (mostly 0, 1, 2) to those textbox controls that require it and `-1` to those that don't depend on ID values for any functionality. These ID values were set for each field in the `symoroui/labels.py` file.
Rename `Symoro` class to `SymbolManager` and place it in `symoroutils/symbolmgr.py`. Update in all places to call `SymbolManager` instead of `Symoro`.
Move functions from `pysymoro/symoro.py` to `symoroutils/tools.py`. These functions are helper functions that are called by other modules.
Fix `NameError` arising from different function calls in `symoroutils/symbolmgr.py` and `symoroutils/tools.py`.
Move initialisation class to `symoroutils/paramsinit.py`. Rename class `Init` to `ParamsInit`. Rename `symoroutils/dyninit.py` to `symoroutils/paramsinit.py`. Update to call `ParamsInit` class instead in all relevant parts.
Update test file to call the right functions and objects.
Add unittest for `symoroutils/filemgr.py` in `symoroutils/tests/test_filemgr.py`. Remove some of the doctest code from `symoroutils/filemgr.py` and move to the corresponding unittest file.
Update calls to `pysymoro.symoro` module with `pysymoro.robot` module.
Move sample robot definitions from `pysymoro/robot.py` module `Robot` class to a new module `symoroutils/samplerobots.py`. Update function calls in all places.
Update unit test file accordingly.
Rename `make_file_path()` to `get_file_path()` in `symoroutils/filemgr.py`. Update all calls.
Modify file path variable in `writepar()` to read from the `Robot` instance.
Modify `symoroui/layout.py` to store the last used robot in the settings file.
Modify to indicate connection with the base link by a black sphere and end-effector (terminal links) by a blue sphere. Remove not needed code.
Fix overlapping issue in visualisation UI. Re-factor and cleanup code.
Refactor in order to unify the DDyM computation for floating base and fixed base robots into the same function `floating_direct_dynmodel()` in `nealgos`.
Rename `floating_direct_dynmodel()` to `direct_dynmodel()` in `nealgos`.
Rename `pysymoro/dynamics.py` to `pysymoro/baseparams.py`. Update module import calls accordingly. Rename function name in `pysymoro/baseparams.py` and update accordingly.
Add `prompt_file_save()` method to `MainFrame` class so that user can rename output files after computation of various models.
Modify in order to prompt to rename output file for all models in `Dynamic` and `Identification` menus. Update other functions accordingly to return the required parameters.
Modify in order to prompt rename of output file for models in `Geometric` and `Kinematic` menus. Update other functions accordingly to return the required parameters.
Save `*_base.par` robot in the same folder after base inertial computation. Modify `readpar()` function to read the robot name from the PAR file and use it during the instantiation of `Robot` class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.