Release 4.2.10#962
Merged
Merged
Conversation
After any project search, the explorer tree displayed the matching
element name as literal markup ("<span class=...") because the
decorated HTML string from extractSearchQuery was passed as the leaf
label, which ProjectTreeLeaf renders as plain text. The decorated
string was also used as the element identity, so rename, duplicate,
and delete targeted a name that does not exist while highlighted.
Pass the plain name as the label everywhere and add a highlightQuery
prop to ProjectTreeLeaf/ProjectTreeExpandableLeaf, which render the
match safely through the existing HighlightedText atom - the same
approach the search results panel already uses.
Fixes #640
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01U5TQ1y3yBEDx73tYTHoUBj
…ighted Address review feedback: selection through a highlighted leaf must record the real POU name, never the decorated display string. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01U5TQ1y3yBEDx73tYTHoUBj
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vq6oTRN4oMe9MUMDEn4c6H
…earch-highlight fix(explorer): stop rendering search-highlight markup as tree labels
BOOL_LOCATION_REGEX only allowed %QX/%IX, so valid IEC memory bits (%MX0.0 — e.g. Modbus coils) were rejected as "Location is invalid", while the word-width regexes already accepted the memory (M) area. Add M so every valid IEC area prefix (I/Q/M) is accepted for BOOL, matching WORD/DWORD/LWORD, and update the BOOL hint to list %MX. Reported: forum "%MX locations now invalid - Runtime v4". Verified in openplc-web: %MX0.0 now accepted on a BOOL; %MZ0.0 still rejected. Also bump APP_VERSION + package.json to 4.2.10 for the patch release. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
fix(variables): accept %MX memory-bit locations for BOOL (v4.2.10)
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promote
development→mainfor the 4.2.10 patch release.%MXmemory-bit locations for BOOL (forum regression "%MX locations now invalid - Runtime v4"). Browser-verified in openplc-web.APP_VERSION+package.json, in sync).After merge, tag
v4.2.10onmainto trigger the Build and Release workflow.🤖 Generated with Claude Code