This repository was archived by the owner on Feb 17, 2025. It is now read-only.
Archeo: Remove text decoration from post titles#5573
Merged
Conversation
8 tasks
MaggieCabrera
approved these changes
Feb 25, 2022
MaggieCabrera
left a comment
MaggieCabrera
left a comment
Contributor
There was a problem hiding this comment.
I agree, and this LGTM, let's move this to approved but not mergeable then and if the GB PR stalls then we can think of an alternative
Contributor
|
mmh, looks like this is the only issue missing before launch, and the home page looks a bit strange with the underline. Should we patch this so we can submit and then introduce this fix when it lands on GB? |
5 tasks
Collaborator
|
I'm still seeing the underlines by default on my local site but the screenshot looks good. If the post titles are underlined on hover, we can merge this. |
Member
Author
|
Let's just merge with a patch |
And tidied up some comments
Member
|
I've added a CSS patch for the text-decoration styles, and I've made sure the post titles are underlined on hover. I think this should be ready to come in now 🤞 |
scruffian
commented
Mar 7, 2022
MaggieCabrera
approved these changes
Mar 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This removes the underline from the post title links on the home page:
Needs WordPress/gutenberg#38986 to work. I'm hesitant to add more CSS for this when the fix in Gutenberg is simple.