Archeo: Add home template#5564
Conversation
kjellr
left a comment
kjellr
left a comment
There was a problem hiding this comment.
This is looking good, thank you!
Not sure if this is the best place to make this change, but the top header should have var(--wp--custom--spacing--outer) padding on the bottom to even it out.
Also, there's a lot of extra padding above the archeo/image-with-headline-description pattern. That should have a top padding of 0 when placed here. (I think it would be fine to remove that padding from the pattern in general).
| <!-- wp:query {"queryId":3,"query":{"pages":0,"offset":0,"postType":"post","order":"desc","orderBy":"date","author":"","search":"","exclude":[],"sticky":"","inherit":false,"perPage":3}} --> | ||
| <div class="wp-block-query"><!-- wp:post-template --> | ||
| <!-- wp:group {"className":"simple-list-of-posts","layout":{"type":"flex","allowOrientation":false}} --> | ||
| <div class="wp-block-group simple-list-of-posts"><!-- wp:post-title {"style":{"typography":{"lineHeight":"1.2","fontStyle":"normal","fontWeight":"100"}},"fontSize":"huge"} /--> |
There was a problem hiding this comment.
The post titles here need to be links — right now nothing is clickable. 😅
There was a problem hiding this comment.
Oh yeah! 😅 I've added links now, although they automatically have an underline. Should we remove this just for this pattern?
There was a problem hiding this comment.
Thanks @mikachan! Can you remove the underline just for this pattern and have it be underlined on hover?
| <!-- wp:post-author-name {"style":{"typography":{"fontStyle":"normal","fontWeight":"100","lineHeight":"1.2"}},"fontSize":"medium"} /--></div> | ||
| <!-- /wp:group --> | ||
| <!-- /wp:post-template --></div> | ||
| <!-- /wp:query --></div> |
There was a problem hiding this comment.
I think this needs pagination. For now, let's just add prev/next links, with no page numbers. The text size can match our nav's text size.
There was a problem hiding this comment.
Great ok, I've added pagination now too:
|
I think this is ready for another review, thanks all! |
scruffian
force-pushed
the
add/archeo-home-template
branch
from
7f3d5d5 to
4f86f48
Compare
4 participants
Changes proposed in this Pull Request:
This adds a home template to Archeo. It also adjusts the spacing in the patterns used on this template to match the comps more.
Screenshot taken without the English translations!