fix(mobile): comment kebab menu desyncs after close#14342
Merged
Conversation
…taps The kebab handler toggled isOpen and isVisible together, but these two pieces of state are intentionally separated: isOpen drives the open/close animation while isVisible controls when the drawer is mounted (kept around during the close animation, then unmounted in onClosed). Toggling both in lock-step lets a tap during the close animation flip them out of sync, leaving the drawer unmounted while state thinks it is open — subsequent taps then need two presses before the menu visibly appears. Make handlePress explicitly open the menu. Dismissal is already handled by onClose/onClosed (row tap, backdrop tap, or swipe down). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
This was referenced May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The kebab handler on mobile comments toggled
isOpenandisVisibletogether, but those two pieces of state intentionally serve different roles:isOpendrives the open/close animationisVisiblecontrols whether the drawer is mounted (kept true during the close animation, set to false inonClosed)Because
onCloseandonClosedflip them on separate ticks, there is a brief window during the close animation whereisOpen=falsebutisVisible=true. A tap on the kebab during that window inverts both via the toggle, leaving the drawer unmounted while state thinks it's open. The next tap then has to dig itself out of the broken state, so the kebab appears not to respond.The fix is to make
handlePressexplicitly open the menu. Closing is already fully owned by the drawer'sonClose/onClosedcallbacks (row tap, backdrop tap, or swipe-down).Test plan
🤖 Generated with Claude Code