fix(mobile): comment kebab menu desyncs after close, requiring extra taps#14343
Closed
dylanjeffers wants to merge 3 commits into
Closed
fix(mobile): comment kebab menu desyncs after close, requiring extra taps#14343dylanjeffers wants to merge 3 commits into
dylanjeffers wants to merge 3 commits into
Conversation
Instruments three key contest interactions following the existing
'Remix Contest:' event prefix and {remixContestId, trackId} property
shape used by the host/pick-winners events:
- REMIX_CONTEST_VIEW: contest page/screen first resolves trackId+eventId
- REMIX_CONTEST_ENTER: user taps Enter Contest / Upload Remix
- REMIX_CONTEST_VIEW_SUBMISSIONS: user opens the submissions tab
Mobile submissions-tab firing uses useFocusedTab from
react-native-collapsible-tab-view because the contest tabs mount
eagerly (lazy: false) — a plain mount effect would fire even for
users who only view the Details tab.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…t sections Bug 1 (web): Align static explore section visibility with SearchResults render condition — hide sections when inputValue is set (during debounce window) in addition to when showSearchResults is true, so Premium and other filters applied via the filter pills always suppress unfiltered curated sections. Bug 2 (web): Guard empty-state tile behind !isPending in AlbumResultsPage and PlaylistResultsPage so the NoResultsTile is not shown while the query is still in its initial loading phase, preventing a spurious empty-state flash when combining "Downloads Available" + "Electronic" genre filters. Bug 3 (mobile): Include category !== 'all' in the showSearch guard on the explore screen so tapping a content-type pill (Tracks, Albums, etc.) immediately shows the filtered SearchResults without requiring a second filter to be added. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…taps The kebab handler toggled isOpen and isVisible together, but these two pieces of state are intentionally separated: isOpen drives the open/close animation while isVisible controls when the drawer is mounted (kept around during the close animation, then unmounted in onClosed). Toggling both in lock-step lets a tap during the close animation flip them out of sync, leaving the drawer unmounted while state thinks it is open — subsequent taps then need two presses before the Edit/Delete menu visibly appears. Make handlePress explicitly open the menu. Dismissal is already handled by onClose/onClosed (row tap, backdrop tap, or swipe down). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isOpenandisVisibletogether with!, but the two are intentionally separated:isOpendrives the open/close animation,isVisiblecontrols when the drawer is mounted (kept around during the close animation, unmounted inonClosed).isOpenwentfalse → true, butisVisiblewas stilltrueand wenttrue → false, leaving the drawer unmounted while state thought it was open. The next tap to open the kebab appeared to do nothing.handlePressexplicitly set both totrue. Dismissal is already handled byonClose/onClosed(row tap, backdrop tap, swipe down).Verified that Edit and Delete remain correctly wired:
replyingAndEditingState.editingCommenton the outerCommentSectionProvider;CommentDrawerFormreads that and submits viaeditComment(id, message, mentions).deleteComment(id, parentCommentId)from@audius/common/context.Test plan
🤖 Generated with Claude Code