Fix Discord RPC crashes on Apple Silicon macs#210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the game crashes on newer macs by using the latest version of discord-game-sdk4j which removed the requirement for a native library.
Note 1: This does not fix any of the issues caused by the new island update, such as fishing islands not being detected and Battle Box Arena not being supported. Fixing those would require switching to Noxesium v3, which is still in beta.
Note 2: I am currently unable to test this on Windows and Linux, please make sure it works there before releasing the update to the public
Closes #175
Closes #61