Skip to content

chore: Update to 1.21.11 and Noxesium v3.0.0#211

Merged
pe3ep merged 11 commits into
AsoDesu:mainfrom
pe3ep:chore/1.21.11-nox-v3
Feb 18, 2026
Merged

chore: Update to 1.21.11 and Noxesium v3.0.0#211
pe3ep merged 11 commits into
AsoDesu:mainfrom
pe3ep:chore/1.21.11-nox-v3

Conversation

@pe3ep

@pe3ep pe3ep commented Jan 20, 2026

Copy link
Copy Markdown
Collaborator

Heya again 😁 !

This PR updates to the latest Minecraft version, as well as the latest Noxesium version, fixing the game detection issues entirely (#208).

Some things are worth noting:

@AsoDesu

AsoDesu commented Jan 21, 2026

Copy link
Copy Markdown
Owner

hiya, was testing things out, it all looks good but i'm just running into one issue

music seems to be playing twice, but the debug logs seem to not mention anything being run twice (except the stop)
image

i seem to be getting this pretty consistently by just having the setting enabled on game start, but it seems to happen regardless of what the setting is set to
if i had to hazzard a guess, i think it's due to the mixins being run at the tail of the method instead of at the head and not cancelling vanilla playing the sound properly? i do think i override the mcci music regardless of the setting so it would make sense (+ i also think i can hear an uncompression version underneath)
they were at the head of the method for that reason, but running after the ensureSameThread check since that WILL cause it to run multiple times. i could be wrong tho if there's something i've missed

other than that, it all looks good to me! :D

@pe3ep
pe3ep merged commit 239e5f5 into AsoDesu:main Feb 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants