Skip to content

New feature: Item progress bars in various menus#189

Open
violine1101 wants to merge 24 commits into
AsoDesu:mainfrom
violine1101:progress-bars
Open

New feature: Item progress bars in various menus#189
violine1101 wants to merge 24 commits into
AsoDesu:mainfrom
violine1101:progress-bars

Conversation

@violine1101

Copy link
Copy Markdown
Contributor

This PR adds item progress bars to various menus (reusing the vanilla code for durability bars).

There are three types of these progress bars. First, a general progress bar (green) for all menu items that have some sort of percentage progress bar in their tooltip. This includes quests, fishing islands, badges, cosmetic groups, and a few more things.

2025-08-23_15 01 00 2025-08-23_15 01 30 2025-08-23_15 00 53

Next, cosmetics that have already been redeemed have a purple progress bar showing how often it has been donated to the royal collection. This was actually the main reason for why I wanted to implement this: I found it difficult to distinguish which cosmetics I already have and which ones I don't. Those which I already redeemed before now have such a bar, and those that are new don't.

2025-08-23_02 43 31 2025-08-23_02 43 14

And finally, there's also bars for cosmetics in the cosmetic collection menu, showing which chroma packs have been unlocked. The bar color changes based on which colors are available :)

2025-08-23_13 15 16

Of course I also added separate config options for these three types of progress bars.

@LukynkaCZE

Copy link
Copy Markdown
Contributor

very cool stuff!

@kispintyi

kispintyi commented Aug 26, 2025

Copy link
Copy Markdown
Contributor

The green color looks weird in this instance, its like they are broken or something which would definitely throw me up, apart from that cool! :D
P.S.: This issue is the same with the unfilled bar too. It looks like it's broken which is weird

@violine1101

Copy link
Copy Markdown
Contributor Author

Thanks for the input! I've done the following changes:

  • Changed the green progress bar to white by default
  • Added a config option to choose a different color for the (regular) progress bars
  • Progress bars will only be completely empty if the progress is absolute zero

Hopefully that solves your issue that the bars make these items look like they're "broken". Let me know what you think!

2025-09-01_02 31 51 (cropped)

@kispintyi

Copy link
Copy Markdown
Contributor

Wow kinda cool, thanks! :D

@LukynkaCZE

Copy link
Copy Markdown
Contributor

Looks good to me but I will wait for @AsoDesu first on her opinion

@LukynkaCZE

Copy link
Copy Markdown
Contributor

Oh yeah I talked to Aso, basically make extra toggle for cosmetics and make it off by default since its actually kinda just blocking the cosmetic (and idt anyone actually really cares about progression there), otherwise good

@violine1101

Copy link
Copy Markdown
Contributor Author

Sounds good! Feel free to just add commits and push to my branch (I believe you should have permission for that).

@AsoDesu

AsoDesu commented Dec 19, 2025

Copy link
Copy Markdown
Owner

very very cool stuff,
i'm gonna have a quick look at it now, i've just merged #209 which has caused a few conflicts (sorry i think i should have merged this one first cuz it's older and bigger lol)
but i do like where this PR is going :D

@AsoDesu

AsoDesu commented Dec 19, 2025

Copy link
Copy Markdown
Owner

cosmetic blueprints currently show the bar as royal donations, but in my opinion these should show progress to having all materials to craft the blueprint, and i think this should be a toggle as well since it might look a little busy and i can see some people not wanting it

image

@AsoDesu

AsoDesu commented Dec 19, 2025

Copy link
Copy Markdown
Owner

this is like the best thing ever oml i'm so sorry i didn't get to this sooner LOL

image

@AsoDesu AsoDesu left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this all looks good to me!
just need conflicts to be resolved and the blueprints issue to be resolved and then we're good to merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request priority:3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants