New feature: Item progress bars in various menus#187
Closed
violine1101 wants to merge 4 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
This PR was closed by GitHub because I renamed my branch from
maintoprogress-bars, see #189 for the new PR (same commits).This PR adds item progress bars to various menus (reusing the vanilla code for durability bars).
There are three types of these progress bars. First, a general progress bar (green) for all menu items that have some sort of percentage progress bar in their tooltip. This includes quests, fishing islands, badges, cosmetic groups, and a few more things.
Next, cosmetics that have already been redeemed have a purple progress bar showing how often it has been donated to the royal collection. This was actually the main reason for why I wanted to implement this: I found it difficult to distinguish which cosmetics I already have and which ones I don't. Those which I already redeemed before now have such a bar, and those that are new don't.
And finally, there's also bars for cosmetics in the cosmetic collection menu, showing which chroma packs have been unlocked. The bar color changes based on which colors are available :)
Of course I also added separate config options for these three types of progress bars.