Skip to content

Add slot functionality to replace hardcoded aria-labels #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmenner merged 2 commits into from
Oct 9, 2025
Merged

Add slot functionality to replace hardcoded aria-labels #362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dedd4ef
feat: add slot functionality in place of aria-labels #357
jordanjones243 Oct 3, 2025
3304621
docs: fix broken example
jordanjones243 Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions apiExamples/ariaLabel.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<auro-button>
<span slot="ariaLabel">My Button Label</span>
Auro Button
</auro-button>

<auro-button loading>
<span slot="ariaLabel.loading">My Loading Button Label</span>
Auro Button
</auro-button>
14 changes: 14 additions & 0 deletions apiExamples/ariaLabelledby.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<auro-button aria-labelledby="button-label">
Auro Button
<label id="button-label" class="util_displayHiddenVisually">My Button Label</label>
</auro-button>

<style>
.util_displayHiddenVisually {
clip: rect(1px, 1px, 1px, 1px);
width: 1px;
height: 1px;
padding: 0;
border: 0;
}
</style>
9 changes: 6 additions & 3 deletions apiExamples/icon.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,15 @@
<auro-button arialabel="wifi">
<auro-button>
<span slot="ariaLabel">wifi</span>
<span>Activate WiFi</span>
<auro-icon customColor category="in-flight" name="wifi"></auro-icon>
</auro-button>
<auro-button variant="secondary" arialabel="arrow-left">
<auro-button variant="secondary">
<span slot="ariaLabel">arrow-left</span>
<span>Previous action</span>
<auro-icon customcolor category="interface" name="arrow-left" ></auro-icon>
</auro-button>
<auro-button variant="tertiary" arialabel="heart-filled">
<auro-button variant="tertiary">
<span slot="ariaLabel">heart-filled</span>
<span>Love this ...</span>
<auro-icon customcolor category="interface" name="heart-filled" ></auro-icon>
</auro-button>
3 changes: 2 additions & 1 deletion apiExamples/roundedRightAlign.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<div style="display: flex; justify-content: flex-end; align-items: center; width: 100%">
<auro-button arialabel="in-flight" shape="circle" id="rightAlignElem">
<auro-button shape="circle" id="rightAlignElem">
<span slot="ariaLabel">in-flight</span>
<span>Text is now shown!</span>
<auro-icon customColor category="interface" name="arrow-up"></auro-icon>
</auro-button>
Expand Down
3 changes: 2 additions & 1 deletion apiExamples/roundedTextOnly.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
<auro-button arialabel="arrow-up" rounded>
<auro-button rounded>
<span slot="ariaLabel">arrow-up</span>
Primary
</auro-button>
3 changes: 2 additions & 1 deletion apiExamples/roundedTextWithIcon.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<auro-button arialabel="in-flight" rounded>
<auro-button rounded>
<span slot="ariaLabel">in-flight</span>
<span>Back to Top</span>
<auro-icon customColor category="interface" name="arrow-up"></auro-icon>
</auro-button>
15 changes: 10 additions & 5 deletions apiExamples/shape-circle.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,20 @@
<auro-button arialabel="home-filled" shape="circle" size="xl">
<auro-button shape="circle" size="xl">
<span slot="ariaLabel">home-filled</span>
<auro-icon customColor category="interface" name="home-filled"></auro-icon>
</auro-button>
<auro-button arialabel="home-filled" shape="circle" size="lg">
<auro-button shape="circle" size="lg">
<span slot="ariaLabel">home-filled</span>
<auro-icon customColor category="interface" name="home-filled"></auro-icon>
</auro-button>
<auro-button arialabel="home-filled" shape="circle" size="md">
<auro-button shape="circle" size="md">
<span slot="ariaLabel">home-filled</span>
<auro-icon customColor category="interface" name="home-filled"></auro-icon>
</auro-button>
<auro-button arialabel="home-filled" shape="circle" size="sm">
<auro-button shape="circle" size="sm">
<span slot="ariaLabel">home-filled</span>
<auro-icon customColor category="interface" name="home-filled"></auro-icon>
</auro-button>
<auro-button arialabel="home-filled" shape="circle" size="xs">
<auro-button shape="circle" size="xs">
<span slot="ariaLabel">home-filled</span>
<auro-icon customColor category="interface" name="home-filled"></auro-icon>
</auro-button>
15 changes: 10 additions & 5 deletions apiExamples/shape-square.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,20 @@
<auro-button arialabel="home-filled" shape="square" size="xl">
<auro-button shape="square" size="xl">
<span slot="ariaLabel">home-filled</span>
<auro-icon customColor category="interface" name="home-filled"></auro-icon>
</auro-button>
<auro-button arialabel="home-filled" shape="square" size="lg">
<auro-button shape="square" size="lg">
<span slot="ariaLabel">home-filled</span>
<auro-icon customColor category="interface" name="home-filled"></auro-icon>
</auro-button>
<auro-button arialabel="home-filled" shape="square" size="md">
<auro-button shape="square" size="md">
<span slot="ariaLabel">home-filled</span>
<auro-icon customColor category="interface" name="home-filled"></auro-icon>
</auro-button>
<auro-button arialabel="home-filled" shape="square" size="sm">
<auro-button shape="square" size="sm">
<span slot="ariaLabel">home-filled</span>
<auro-icon customColor category="interface" name="home-filled"></auro-icon>
</auro-button>
<auro-button arialabel="home-filled" shape="square" size="xs">
<auro-button shape="square" size="xs">
<span slot="ariaLabel">home-filled</span>
<auro-icon customColor category="interface" name="home-filled"></auro-icon>
</auro-button>
6 changes: 3 additions & 3 deletions apiExamples/static.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,14 @@
<br><br>

<auro-button static shape="pill">
<auro-icon name="home" slot="icon" customColor></auro-icon>
<auro-icon category="interface" name="home-filled" slot="icon" customColor></auro-icon>
Static Pill with Icon
</auro-button>

<auro-button static shape="circle">
<auro-icon name="home" customColor></auro-icon>
<auro-icon category="interface" name="home-filled" customColor></auro-icon>
</auro-button>

<auro-button static shape="square">
<auro-icon name="home" customColor></auro-icon>
<auro-icon category="interface" name="home-filled" customColor></auro-icon>
</auro-button>
3 changes: 2 additions & 1 deletion apiExamples/toggledText.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<auro-button arialabel="arrow-up" shape="circle" id="toggledTextElem">
<auro-button shape="circle" id="toggledTextElem">
<span slot="ariaLabel">arrow-up</span>
<span>Text is now shown!</span>
<auro-icon customColor category="interface" name="arrow-up"></auro-icon>
</auro-button>
1 change: 0 additions & 1 deletion demo/api.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@
<script src="https://cdn.jsdelivr.net/npm/@aurodesignsystem/auro-accordion@latest/dist/auro-accordion__bundled.js" type="module"></script>
<script src="https://cdn.jsdelivr.net/npm/@aurodesignsystem/auro-alert@latest/dist/auro-alert__bundled.js" type="module"></script>
<script src="https://cdn.jsdelivr.net/npm/@aurodesignsystem/auro-icon@latest/dist/auro-icon__bundled.js" type="module"></script>
<script src="https://cdn.jsdelivr.net/npm/@aurodesignsystem-dev/auro-formkit@0.0.0-pr624.55/auro-input/+esm" type="module"></script>

<script src="https://cdn.jsdelivr.net/npm/marked@latest/marked.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/prismjs@latest/prism.js"></script>
Expand Down
Loading
Loading