Skip to content

Add slot functionality to replace hardcoded aria-labels#362

Merged
rmenner merged 2 commits into
devfrom
jjones/feat/englishAriaLabelsToSlots/#357
Oct 9, 2025
Merged

Add slot functionality to replace hardcoded aria-labels#362
rmenner merged 2 commits into
devfrom
jjones/feat/englishAriaLabelsToSlots/#357

Conversation

@jordanjones243

@jordanjones243 jordanjones243 commented Oct 3, 2025

Copy link
Copy Markdown
Contributor

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

@jordanjones243 jordanjones243 self-assigned this Oct 3, 2025

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @jordanjones243, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@jordanjones243
jordanjones243 requested a review from a team October 3, 2025 19:39
@jordanjones243 jordanjones243 linked an issue Oct 3, 2025 that may be closed by this pull request
chrisfalaska
chrisfalaska previously approved these changes Oct 3, 2025

@chrisfalaska chrisfalaska left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built locally and tested. Looks great! 🚀

@jordanjones243
jordanjones243 changed the base branch from main to dev October 3, 2025 20:54
@jordanjones243
jordanjones243 dismissed chrisfalaska’s stale review October 3, 2025 20:54

The base branch was changed.

@jordanjones243
jordanjones243 force-pushed the jjones/feat/englishAriaLabelsToSlots/#357 branch from 2cc966f to b2cbf28 Compare October 3, 2025 20:54
@github-actions

github-actions Bot commented Oct 3, 2025

Copy link
Copy Markdown

🚀 PR Release Published! v0.0.0-pr362.3

To install:

npm install @aurodesignsystem-dev/auro-button@0.0.0-pr362.3

Install via alias:

npm install @aurodesignsystem/auro-button@npm:@aurodesignsystem-dev/auro-button@0.0.0-pr362.3

View on npmjs.com

@github-actions

github-actions Bot commented Oct 3, 2025

Copy link
Copy Markdown

Component Demo Links

button: https://auro-button-362.surge.sh

@jordanjones243
jordanjones243 force-pushed the jjones/feat/englishAriaLabelsToSlots/#357 branch 2 times, most recently from c51df83 to fa8f8a1 Compare October 6, 2025 22:06
@jordanjones243
jordanjones243 requested a review from a team as a code owner October 6, 2025 22:06
@jordanjones243
jordanjones243 force-pushed the jjones/feat/englishAriaLabelsToSlots/#357 branch 3 times, most recently from 412a0c9 to f7308f5 Compare October 9, 2025 15:58
Comment thread src/auro-button.js Outdated
@jordanjones243
jordanjones243 force-pushed the jjones/feat/englishAriaLabelsToSlots/#357 branch 2 times, most recently from 22f9515 to e94b201 Compare October 9, 2025 16:58
StephenRiosDev
StephenRiosDev previously approved these changes Oct 9, 2025
@rmenner rmenner mentioned this pull request Oct 9, 2025
@rmenner
rmenner merged commit 39d1eee into dev Oct 9, 2025
16 of 19 checks passed
@rmenner
rmenner deleted the jjones/feat/englishAriaLabelsToSlots/#357 branch October 9, 2025 17:31
@github-actions

github-actions Bot commented Oct 9, 2025

Copy link
Copy Markdown

🎉 This PR is included in version 12.0.0-rc-365.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions

github-actions Bot commented Oct 9, 2025

Copy link
Copy Markdown

🎉 This PR is included in version 12.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions Bot added the released Completed work has been released label Oct 9, 2025
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 12.0.0-rc-368.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 12.0.0-rc-384.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 12.0.0-rc-391.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown

🎉 This PR is included in version 12.0.0-rc-395.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add slots for hardcoded English aria attributes

4 participants