Skip to content

fix: set tokens on :host level to allow customization #354 #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmenner merged 1 commit into from
Oct 1, 2025
Merged

fix: set tokens on :host level to allow customization #354 #355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions demo/api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,24 +685,13 @@ The component may be restyled using the following code sample and changing the v
```scss
@use "@aurodesignsystem/design-tokens/dist/themes/alaska/SCSSVariables--alaska" as v;

:host(:not([onDark])) {
:host {
--ds-auro-button-border-color: var(--ds-advanced-color-button-primary-border, #{v.$ds-advanced-color-button-primary-border});
--ds-auro-button-border-inset-color: var(--ds-advanced-color-state-focused-inverse, #{v.$ds-advanced-color-state-focused-inverse});
--ds-auro-button-container-color: var(--ds-advanced-color-button-primary-background, #{v.$ds-advanced-color-button-primary-background});
--ds-auro-button-container-image: var(--ds-advanced-color-button-primary-background, #{v.$ds-advanced-color-button-primary-background});
--ds-auro-button-loader-color: var(--ds-advanced-color-button-primary-text, #{v.$ds-advanced-color-button-primary-text});
--ds-auro-button-text-color: var(--ds-advanced-color-button-primary-text, #{v.$ds-advanced-color-button-primary-text});
--ds-auro-button-tap-color: transparent;
}

:host([onDark]) {
--ds-auro-button-border-color: var(--ds-advanced-color-button-primary-border-inverse, #{v.$ds-advanced-color-button-primary-border-inverse});
--ds-auro-button-border-inset-color: var(--ds-advanced-color-state-focused-inverse, #{v.$ds-advanced-color-state-focused-inverse});
--ds-auro-button-container-color: var(--ds-advanced-color-button-primary-background-inverse, #{v.$ds-advanced-color-button-primary-background-inverse});
--ds-auro-button-container-image: var(--ds-advanced-color-button-primary-background-inverse, #{v.$ds-advanced-color-button-primary-background-inverse});
--ds-auro-button-loader-color: var(--ds-advanced-color-button-primary-text-inverse, #{v.$ds-advanced-color-button-primary-text-inverse});
--ds-auro-button-text-color: var(--ds-advanced-color-button-primary-text-inverse, #{v.$ds-advanced-color-button-primary-text-inverse});
--ds-auro-button-tap-color: transparent;
}
```
<!-- AURO-GENERATED-CONTENT:END -->
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

49 changes: 49 additions & 0 deletions src/auro-button.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,24 @@
static: {
type: Boolean,
reflect: true
},

/**
* @private
*/
onHover: {
attribute: 'data-hover',
type: Boolean,
reflect: true
},

/**
* @private
*/
onActive: {
attribute: 'data-active',
type: Boolean,
reflect: true
}
};
}
Expand Down Expand Up @@ -390,6 +408,32 @@
this.runtimeUtils.handleComponentTagRename(this, 'auro-button');
}

/**
* This is to detect pointer events for hover and active states for styling purposes.

Check warning on line 412 in src/auro-button.js

View workflow job for this annotation

GitHub Actions / test (20) 

Sentences must end with a period

Check warning on line 412 in src/auro-button.js

View workflow job for this annotation

GitHub Actions / test (22) 

Sentences must end with a period
* :host with :has selector dont work together in Safari and Firefox
* @param {PointerEvent} event - The pointer event.
* @private
*/
onPointerEvent(event) {
switch (event.type) {
case 'pointerenter':
this.onHover = true;
break;
case 'pointerleave':
this.onHover = false;
break;
case 'pointerdown':
this.onActive = true;
break;
case 'pointerup':
case 'blur':
this.onActive = false;
break;
default:
break;
}
}

/**
* Renders the default layout for the button.
* @returns {TemplateResult}
Expand Down Expand Up @@ -440,6 +484,11 @@
variant="${ifDefined(this.variant ? this.variant : undefined)}"
.value="${ifDefined(this.value ? this.value : undefined)}"
@click="${!this.static && this.type === 'submit' ? this.surfaceSubmitEvent : undefined}"
@pointerenter="${this.onPointerEvent}"
@pointerleave="${this.onPointerEvent}"
@pointerdown="${this.onPointerEvent}"
@pointerup="${this.onPointerEvent}"
@blur="${this.onPointerEvent}"
href="${ifDefined(this.buttonHref || undefined)}"
target="${ifDefined(this.buttonTarget || undefined)}"
rel="${ifDefined(this.buttonRel || undefined)}"
Expand Down
Loading
Loading