fix: set tokens on :host level to allow customization #354#355
Merged
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
Surge demo deployment failed! 😭 |
sun-mota
force-pushed
the
sunMota/customizing-token-bug
branch
from
September 26, 2025 17:56
5e2c8d5 to
ba06bc2
Compare
7 tasks
Contributor
|
I am noticing color differences against the live DocSite 
|
Member
Author
sun-mota
force-pushed
the
sunMota/customizing-token-bug
branch
from
October 1, 2025 17:16
ba06bc2 to
ff308de
Compare
sun-mota
force-pushed
the
sunMota/customizing-token-bug
branch
from
October 1, 2025 17:19
ff308de to
e0ac8a7
Compare
chrisfalaska
approved these changes
Oct 1, 2025
chrisfalaska
left a comment
chrisfalaska
left a comment
Contributor
There was a problem hiding this comment.
Tested and built locally. Looks great! 🚀
Contributor
|
🎉 This PR is included in version 11.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alaska Airlines Pull Request
Issue
Customizing with tokens weren’t working because tokens were re-defined on
auro-buttonunder shadowDom, which overrode consumer values.Solution
Define all token values on
:hostlevel and have internal rules only consume them. This way, consumers can override and the cascade works as expected.Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team