Skip to content

Add new cruise icons #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jordanjones243 wants to merge 1 commit into
base: master
Choose a base branch
from
+18 −2
Open

Add new cruise icons #377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/data/icons.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1391,6 +1391,16 @@
"category": "destination",
"deprecated": true
},
{
"name": "cruise-stroke",
"desc": "An outlined icon of a cruise ship sitting on a wave of water.",
"category": "destination"
},
{
"name": "cruise-filled",
"desc": "A solid icon of a cruise ship sitting on a wave of water.",
"category": "destination"
},
{
"name": "ride-stroke",
"desc": "Indicates options for transportation.",
Expand Down
3 changes: 3 additions & 0 deletions src/icons/ cruise-stroke.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions src/icons/cruise-filled.svg
View file
Open in desktop

@jason-capsule42 jason-capsule42 Jul 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This SVG looks wrong - shouldn't it be the same size the the stroke version?

@jordanjones243 jordanjones243 Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are the same size, confirmed by Claude:

Yep, they're the same size 👍 Both sit on a 24×24 canvas and the ship fills the same box, so filled and stroke match up:

Icon Canvas (viewBox) Artwork bounds (x) Artwork bounds (y)
cruise-filled 0 0 24 24 1.40 → 22.60 2.31 → 21.69
cruise-stroke 0 0 24 24 1.40 → 22.60 2.31 → 21.69

Same scale, same position — good to go ✅

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions src/icons/cruise-stroke.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading