Add new cruise icons#377
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds new cruise-themed icons to the design system and wires them into the icon metadata so they can be consumed like existing icons. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- There appears to be a leading space in the new file path
src/icons/ cruise-stroke.svg; please confirm the actual filename doesn’t include this space and is consistent with the rest of the icon set. - Double-check that the new
cruise-strokeandcruise-filledicon names and variants are aligned with the existing naming conventions and structure used inicons.json(e.g., key names, style variants, and ordering).
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- There appears to be a leading space in the new file path `src/icons/ cruise-stroke.svg`; please confirm the actual filename doesn’t include this space and is consistent with the rest of the icon set.
- Double-check that the new `cruise-stroke` and `cruise-filled` icon names and variants are aligned with the existing naming conventions and structure used in `icons.json` (e.g., key names, style variants, and ordering).Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
This SVG looks wrong - shouldn't it be the same size the the stroke version?
There was a problem hiding this comment.
They are the same size, confirmed by Claude:
Yep, they're the same size 👍 Both sit on a 24×24 canvas and the ship fills the same box, so filled and stroke match up:
| Icon | Canvas (viewBox) | Artwork bounds (x) | Artwork bounds (y) |
|---|---|---|---|
cruise-filled |
0 0 24 24 |
1.40 → 22.60 | 2.31 → 21.69 |
cruise-stroke |
0 0 24 24 |
1.40 → 22.60 | 2.31 → 21.69 |
Same scale, same position — good to go ✅
devhowyalike
left a comment
There was a problem hiding this comment.
I notice crusie-stroke.svg has this:
<svg width="24" height="24" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg">
But cruise-fileld.svg has just this:
<svg>
This is probably why the GitHub PR shows them as different sizes when looking at the changes. |
b7b2f52 to
05d2fd9
Compare
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: https://itsals.visualstudio.com/E_Retain_Content/_workitems/edit/1458948
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
Type of change:
Rendered Icons
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
New Features: