engineering-loop: ship loop traces to collector

[Svaag]

Summary

• pin engineering-loop to trace: ship engineering events through sink_from_env engineering-loop#26 with agent-core v0.4.0 sink_from_env support
• pin Knowledge MCP/Knowledge Loop to trace: ship knowledge events through sink_from_env knowledge#24 with collector-capable emission
• configure Engineering Loop, Knowledge MCP, and the daily Knowledge Loop canary to post TraceEvents to the loop-local collector
• keep Engineering Loop JSONL trace fallback and keep Knowledge Loop live OpenRouter budget at 0 / max 1 reviewed PR per day

Validation

• git diff --check origin/main..HEAD
• scripts/ci/render-all.sh
• python3 -m unittest discover -s tests/iac -p test_*.py
• scripts/ci/iac-static.sh
• yamllint ansible/roles/engineering_loop ansible/roles/knowledge_mcp ansible/roles/knowledge_loop ansible/inventory/host_vars/loop.yml

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ❌ 26 - Not compliant Non-compliant requirements: PR does not modify any vault_agent templates or noc-agent configuration. No changes to noc-agent restart logic or Icinga alerts. Requires further human verification: No items require verification; PR is entirely unrelated to this ticket. 24 - Not compliant Non-compliant requirements: PR does not introduce any dom0 role, inventory changes, or monitoring adjustments. Requires further human verification: No items require verification; PR is entirely unrelated to this ticket.

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

🏅 Score: 95

🧪 PR contains tests

🔒 No security concerns identified

⚡ No major issues detected

[github-actions]

PR Code Suggestions ✨

No code suggestions found for the PR.

[Svaag]

PR-agent ticket compliance note is a false association from cross-repo PR references (AS215932/engineering-loop#26 and AS215932/knowledge#24) used to identify the producer SHAs. This PR is not intended to close network-operations issues #26 or #24. The relevant rollout items are the agent-core trace pipeline steps: loop producer collector wiring and the conservative Knowledge Loop canary.

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. 👍

Reviewed commit: 7ef1909f0e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".