Skip to content

deploy: bump Knowledge for MCP image git fix#318

Merged
Svaag merged 1 commit into
mainfrom
deploy/knowledge-docker-git-fix
Jun 29, 2026
Merged

deploy: bump Knowledge for MCP image git fix#318
Svaag merged 1 commit into
mainfrom
deploy/knowledge-docker-git-fix

Conversation

@Svaag

@Svaag Svaag commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Summary

Why

The #315 production apply failed while building the Knowledge MCP image because uv sync needs git to resolve the pinned agent-core dependency inside the Docker build. AS215932/knowledge#25 installs git in the runtime image.

Validation

  • pytest tests/iac/test_app_version_pins.py
  • git diff --check
  • cd ansible && ansible-playbook playbooks/engineering-loop.yml --syntax-check

@Svaag Svaag requested a review from a team as a code owner June 29, 2026 16:42
@github-actions

Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ❌

25 - Not compliant

Non-compliant requirements:

  • All six requirements are not addressed in this PR (firewall bogon management is untouched)

315 - Partially compliant

Compliant requirements:

Non-compliant requirements:

Requires further human verification:

  • Actual live deployment and trace emission verification (whether the new image builds and collector accepts traces) cannot be confirmed via diff alone
  • Validation scripts (render-all, unit tests, lint) need to pass on the final branch before merge
⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🏅 Score: 85
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

@github-actions

Copy link
Copy Markdown
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

@Svaag

Svaag commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

PR-agent ticket compliance notes:

  • AS215932/knowledge#25 is a cross-repo PR reference, not network-operations issue firewall: codify /etc/pf.bogons6 in Ansible firewall role + remove ff00::/8 #25. This PR is intentionally unrelated to firewall bogon management.
  • network-operations#315 is already merged; this is a narrow follow-up to repair its production apply failure by bumping Knowledge pins to the image-build fix. The engineering-loop pin was already set by engineering-loop: ship loop traces to collector #315 and remains intentionally unchanged.
  • The final branch CI has now run the full repository gates for this PR: render, lint, semgrep, static-iac, ansible-idempotency, batfish, containerlab-frr, iac-gate, and Semgrep OSS are all green.

Local validation before opening: pytest tests/iac/test_app_version_pins.py, git diff --check, and cd ansible && ansible-playbook playbooks/engineering-loop.yml --syntax-check.

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 336f81048a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Svaag Svaag merged commit 755d601 into main Jun 29, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant