chore: depend on agent-core v0.1.0 (uv git source, public, zero CI-auth)#21
Conversation
…on availability Pin the now-public AS215932/agent-core at tag v0.1.0 via uv git source, making the flag-gated agent-core TraceEvent/CostUsage emitter's dependency always present (zero CI-auth: public repo). Emission stays OFF by default (HYRULE_KNOWLEDGE_AGENT_CORE_TRACE); this only guarantees availability so it can be enabled via deployment env. uv.lock pins commit 591e3a0. ruff + mypy --strict clean; suite 97 passed (emitter tests now run in CI). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5f4111ad99
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| testpaths = ["tests"] | ||
|
|
||
| [tool.uv.sources] | ||
| agent-core = { git = "https://github.com/AS215932/agent-core", tag = "v0.1.0" } |
There was a problem hiding this comment.
This new git source makes the documented container build hit a Git clone during RUN uv sync --frozen --no-dev --extra mcp in Dockerfile:24, but that image only installs ca-certificates and curl before the sync step, not git (Dockerfile:12-14). uv shells out to git for this source, so a clean python:3.12-slim build will fail before the MCP image can be produced; either install git in the image before syncing or avoid a git source for the runtime build.
Useful? React with 👍 / 👎.
1 participant
Pins the now-public
AS215932/agent-coreat tagv0.1.0as a real dependency via uvgit source, so the Phase 2 flag-gated emitter's dependency is always present (no optional
import needed at runtime; zero CI-auth because the repo is public).
pyproject.toml:agent-coreadded todependencies+[tool.uv.sources](tagv0.1.0).uv.lock: regenerated; pins agent-core git commit591e3a0.Behavior
HYRULE_KNOWLEDGE_AGENT_CORE_TRACEgates it. This PRonly guarantees availability; enable per-environment via deploy env.
ruffclean,mypy --strict srcclean (36 files),pytest97 passed(the emitter tests now run instead of being skipped, since agent-core is installed).
🤖 Generated with Claude Code