knowledge MCP: emit agent-core TraceEvent on knowledge_context_pack (live path)#23
Merged
Conversation
The live knowledge path engineering-loop queries is the MCP server, not the CLI. Wire emit_context_pack into the knowledge_context_pack tool (mirrors cmd_context_pack) so the running MCP server emits a context-pack TraceEvent. Flag-gated + best-effort (off by default; no-op without HYRULE_KNOWLEDGE_AGENT_CORE_TRACE). ruff + mypy --strict clean; 97 tests pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2 wired emission into the CLI (
cmd_context_pack) + enrich path, but the liveknowledge path engineering-loop uses is the MCP server (
knowledge_context_packtool).This wires
emit_context_packthere too, so the running MCP server emits a context-packTraceEventper call.mcp_server.py:knowledge_context_packnowemit_context_pack(data)before returning.HYRULE_KNOWLEDGE_AGENT_CORE_TRACE);agent_corealready a dep (PR chore: depend on agent-core v0.1.0 (uv git source, public, zero CI-auth) #21), so the MCP container build includes it.mypy --strict srcclean; full suite 97 passed.To actually emit from the deployed MCP container, the knowledge_mcp role still needs the flag
🤖 Generated with Claude Code