chore: remove dead legacy entity-selection component tree (#688)#696
Open
grzanka wants to merge 2 commits into
Open
chore: remove dead legacy entity-selection component tree (#688)#696grzanka wants to merge 2 commits into
grzanka wants to merge 2 commits into
Conversation
The pre-Stage-8 entity selector (entity-combobox, entity-selection-comboboxes, entity-selection-panels, entity-panel) was superseded by the entity-selection/ subtree and is no longer imported by the app — only referenced by its own tests and one stale comment. Delete the four components and their four test files (~1,250 LOC), and repoint the program-kind.ts comment to describe the grouping logic directly instead of a deleted component. https://claude.ai/code/session_01HTEUmMLhvekjFKT6JimhAV
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes an obsolete, pre-Stage-8 entity-selection component/test tree that is no longer used by the running app (superseded by the src/lib/components/entity-selection/ subtree), and updates related documentation/logging references.
Changes:
- Deleted 4 legacy entity-selection components and 4 associated test files (~1,250 LOC) that were no longer imported by the app.
- Updated
src/lib/utils/program-kind.tsdoc comment to describe program-grouping logic directly (instead of pointing at a deleted UI file). - Added AI session logging updates (new log file, changelog entry, and log index update).
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/lib/components/entity-combobox.svelte | Deleted dead legacy combobox component. |
| src/lib/components/entity-selection-comboboxes.svelte | Deleted dead legacy compact-mode wrapper component. |
| src/lib/components/entity-selection-panels.svelte | Deleted dead legacy panel-mode wrapper component. |
| src/lib/components/entity-panel.svelte | Deleted dead legacy panel component. |
| src/tests/components/entity-combobox.test.ts | Deleted tests for removed legacy combobox. |
| src/tests/components/entity-panel.test.ts | Deleted tests for removed legacy panel. |
| src/tests/unit/entity-selection-comboboxes.test.ts | Deleted unit tests for removed legacy combobox wrapper. |
| src/tests/unit/entity-selection-panels.test.ts | Deleted unit tests for removed legacy panels wrapper. |
| src/lib/utils/program-kind.ts | Replaced stale “source of truth” reference with an inline grouping-rule description. |
| docs/ai-logs/README.md | Added the new session log to the AI logs index table. |
| docs/ai-logs/2026-06-03-entity-selection.md | Added detailed AI session log for the dead-code removal. |
| CHANGELOG-AI.md | Added a new changelog entry linking to the session log. |
Resolve CHANGELOG-AI.md and docs/ai-logs/README.md conflicts (keep both the #688 dead-code removal and the #687/#631 docs-sync entries). Address PR #696 review: remove now-dangling references to the deleted entity-selection components from the authoritative current-state docs and the e2e comment that cited them: - docs/03-architecture.md: legacy picker paragraph -> note removal in #688 - docs/04-feature-specs/entity-selection.md: label-sharing text now points at the live entity-selection/ subtree; version note marks the components removed - tests/e2e/particle-unit-switching.spec.ts: drop the dead-file citation from the omitted-electron-scenario comment https://claude.ai/code/session_01HTEUmMLhvekjFKT6JimhAV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #688.
What
Removes the pre-Stage-8 entity-selection implementation that was superseded by
the
entity-selection/subtree (entity-selection.svelte, wired into both thecalculator and plot pages) but never deleted.
Deleted (4 components + 4 tests, ~1,250 LOC of dead code):
src/lib/components/entity-combobox.sveltesrc/lib/components/entity-selection-comboboxes.sveltesrc/lib/components/entity-selection-panels.sveltesrc/lib/components/entity-panel.sveltesrc/tests/components/entity-combobox.test.tssrc/tests/components/entity-panel.test.tssrc/tests/unit/entity-selection-comboboxes.test.tssrc/tests/unit/entity-selection-panels.test.tsAlso repointed the stale doc comment in
src/lib/utils/program-kind.ts— itcited the (now-deleted)
entity-selection-comboboxes.svelteas the "source oftruth" for program grouping; it now describes the grouping rule directly, with
the feature spec remaining the canonical reference.
Why
These files were not imported anywhere in the app. The only non-test references
were the dead components importing each other and that one stale comment, which
was itself a maintenance trap (a fix to grouping made there would have had zero
effect). They also inflated test coverage with code no user can reach. See #688
for the full rationale.
Verification
pnpm format/pnpm run format:check— cleanpnpm lint— 0 errorspnpm check(svelte-check + tsc) — 0 errors, 0 warningspnpm test— 1639 passed. The only failures are 3 tests inguard-forbidden-files.test.ts, which are pre-existing and unrelated: thetest creates a temp git repo and runs
git commit, which fails on thissandbox's commit-signing server (
signing server returned status 400: missing source); reproduced identically with a plaingit commitin a throwaway repo.The test does not reference entity-selection.
Notes
program-kind.test.tsis retained, so program-grouping logic stays covered.docs/progress/anddocs/ai-logs/are left intactas point-in-time records.
AI logging
CHANGELOG-AI.mdentry added; detailed log atdocs/ai-logs/2026-06-03-entity-selection.md;docs/ai-logs/README.mdindexupdated.
https://claude.ai/code/session_01HTEUmMLhvekjFKT6JimhAV
Generated by Claude Code