docs: add libdedx migration plan for wasm/dedx_extra.c helpers#704
Open
grzanka wants to merge 3 commits into
Open
docs: add libdedx migration plan for wasm/dedx_extra.c helpers#704grzanka wants to merge 3 commits into
grzanka wants to merge 3 commits into
Conversation
Inventory every symbol in wasm/dedx_extra.c and map it to its upstream home in libdedx (dedx.h / dedx_tools.h / dedx_wrappers.h), with a phased PR plan and sequencing against open issues/PRs in both repos. Flags two concrete wins: the duplicated material display-name table (C vs src/lib/config/material-names.ts) and the inverse-STP branch- selection bug worked around locally that should be fixed upstream.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new documentation artifact that inventories wasm/dedx_extra.c helpers and proposes a phased plan for upstreaming them into APTG/libdedx, including sequencing against related issues/PRs and highlighting two high-value deduplication/correctness wins (material display names + inverse-STP branch selection).
Changes:
- Added
docs/12-libdedx-migration-plan.mdwith a per-symbol inventory and phased migration plan (A–F) intodedx.h/dedx_tools.h/dedx_wrappers.h. - Indexed the new document in
docs/README.md. - Logged the session in
CHANGELOG-AI.md(but currently missing the required nested log link line).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| docs/README.md | Adds the new migration-plan doc to the docs index. |
| docs/12-libdedx-migration-plan.md | New migration-plan doc: symbol inventory, phased upstreaming plan, and cross-repo sequencing notes. |
| CHANGELOG-AI.md | Adds an AI session entry for the documentation work. |
Comment on lines
+20
to
+21
| - 2026-06-04 — **Docs / libdedx migration**: Added `docs/12-libdedx-migration-plan.md` — a phased plan to migrate C helpers from `wasm/dedx_extra.c` upstream into `libdedx`. Includes a per-symbol inventory (which of the 810 LOC belong in `dedx.h` / `dedx_tools.h` / `dedx_wrappers.h`), flags the duplicated material display-name table (C vs `src/lib/config/material-names.ts`) and the inverse-STP branch-selection bug that should be fixed upstream, and sequences the work across libdedx issues (#79, #51, #48, #6, #86, #95) and the dedx_web follow-ups (#175, #176, #504). Filed the upstream issues: tracking epic libdedx#118 with per-phase sub-issues libdedx#119–#123 (Phase F = existing #79), cross-referenced to the health-review epic #108 to avoid duplication. Indexed in `docs/README.md`. (Claude Opus 4.8 via Claude Code) | ||
|
|
| - **#95** (Bethe nucleon mass) and **#96** (table-generation script) are | ||
| independent; not blockers, but Phase C tests should pin reference values so a | ||
| later #95 change is caught. | ||
| - There are currently **no open libdedx PRs** — clean slate to land Phase A. |
Comment on lines
+202
to
+205
| benefit from Phase C/E once correctness moves upstream. The current open web | ||
| PRs (**#696–#703**) are unrelated (Svelte refactors + dependabot) and do **not** | ||
| conflict with the migration — sequence migration PRs after the in-flight | ||
| `dedx_extra`-touching work, of which there is none. |
- Replace point-in-time PR-state claims in the migration plan with durable sequencing rules keyed on the files a PR touches (no enumerated PR numbers) - Add the missing CHANGELOG-AI.md `Log:` link and create the session log, indexed in docs/ai-logs/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inventory every symbol in wasm/dedx_extra.c and map it to its upstream
home in libdedx (dedx.h / dedx_tools.h / dedx_wrappers.h), with a phased
PR plan and sequencing against open issues/PRs in both repos.
Flags two concrete wins: the duplicated material display-name table
(C vs src/lib/config/material-names.ts) and the inverse-STP branch-
selection bug worked around locally that should be fixed upstream.