Skip to content

keyfix #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nbassler merged 1 commit into from
Apr 26, 2026
Merged

keyfix #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ android {
}
storePassword = System.getenv("KEYSTORE_PASSWORD") ?: ""
keyAlias = System.getenv("KEY_ALIAS") ?: "dedx-upload"
keyPassword = System.getenv("KEYSTORE_PASSWORD") ?: ""
keyPassword = System.getenv("KEY_PASSWORD") ?: System.getenv("KEYSTORE_PASSWORD") ?: ""
Copy link

Copilot AI Apr 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build now supports a separate key password via KEY_PASSWORD, but the release GitHub Actions workflow currently only exports KEYSTORE_PASSWORD (see .github/workflows/release.yml:38-42). If the key password differs from the keystore password, the CI release signing will still fail because it will fall back to KEYSTORE_PASSWORD. Consider updating the release workflow/secrets (and any docs) to set KEY_PASSWORD when needed, or explicitly document that both passwords must match.

Suggested change
keyPassword = System.getenv("KEY_PASSWORD") ?: System.getenv("KEYSTORE_PASSWORD") ?: ""
keyPassword = System.getenv("KEY_PASSWORD") ?: ""

Copilot uses AI. Check for mistakes.
}
}
compileSdk = 34
Expand Down
Loading