Conversation
There was a problem hiding this comment.
Pull request overview
Updates Android release signing configuration to allow specifying a separate key password via environment variable.
Changes:
- Use
KEY_PASSWORD(with fallback toKEYSTORE_PASSWORD) forsigningConfigs.release.keyPassword.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| storePassword = System.getenv("KEYSTORE_PASSWORD") ?: "" | ||
| keyAlias = System.getenv("KEY_ALIAS") ?: "dedx-upload" | ||
| keyPassword = System.getenv("KEYSTORE_PASSWORD") ?: "" | ||
| keyPassword = System.getenv("KEY_PASSWORD") ?: System.getenv("KEYSTORE_PASSWORD") ?: "" |
There was a problem hiding this comment.
The build now supports a separate key password via KEY_PASSWORD, but the release GitHub Actions workflow currently only exports KEYSTORE_PASSWORD (see .github/workflows/release.yml:38-42). If the key password differs from the keystore password, the CI release signing will still fail because it will fall back to KEYSTORE_PASSWORD. Consider updating the release workflow/secrets (and any docs) to set KEY_PASSWORD when needed, or explicitly document that both passwords must match.
| keyPassword = System.getenv("KEY_PASSWORD") ?: System.getenv("KEYSTORE_PASSWORD") ?: "" | |
| keyPassword = System.getenv("KEY_PASSWORD") ?: "" |
No description provided.