Skip to content

docs(auth): specify big-endian byte order for timestamp in HMAC input #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VasilevNStas wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docs(auth): specify big-endian byte order for timestamp in HMAC input #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions auth.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,13 @@ message Auth {
uint32 timestamp = 2;

// Truncated HMAC-SHA256 (12 bytes) over (client_id || timestamp),
// computed with the pre-shared key issued to this client. Proves
// possession of the PSK without revealing it. Receivers MUST
// assert len(hmac) == 12 and reject the Auth before performing any
// comparison; a shorter or absent value weakens authentication
// non-deterministically across implementations.
// computed with the pre-shared key issued to this client. The
// timestamp is serialised as 4 bytes in big-endian (network byte
// order) before concatenation. Proves possession of the PSK
// without revealing it. Receivers MUST assert len(hmac) == 12
// and reject the Auth before performing any comparison; a shorter
// or absent value weakens authentication non-deterministically
// across implementations.
bytes hmac = 3;

// Free-form device label reported by the client (e.g. "SM-G998B",
Expand Down