docs(auth): specify big-endian byte order for timestamp in HMAC input#43
Open
VasilevNStas wants to merge 1 commit into
Open
docs(auth): specify big-endian byte order for timestamp in HMAC input#43VasilevNStas wants to merge 1 commit into
VasilevNStas wants to merge 1 commit into
Conversation
Contributor
Author
|
@davvd plz review |
Member
|
@VasilevNStas we have merge conflicts here, please resolve them and we'll merge |
VasilevNStas
force-pushed
the
11-docs/hmac-byte-order
branch
from
July 4, 2026 18:02
d177df8 to
d5298ce
Compare
Contributor
Author
|
@davvd conflicts resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Specifies the byte order for timestamp serialization in the HMAC input for
Auth.hmac. No wire changes.Problem
The
hmaccomment states the tag is computed over(client_id || timestamp), wheretimestampis auint32. Proto3 varint encoding applies only to the wire format; the HMAC input is a raw byte string assembled outside any wire format. Without an explicit byte order, Go (big-endian convention) and Swift/Kotlin (little-endian) implementations produce different HMAC inputs for the same(client_id, timestamp)pair, causing silent authentication failures.Fix
Added one sentence: "The timestamp is serialised as 4 bytes in big-endian (network byte order) before concatenation."
Closes #11