Skip to content

fix(pong)!: change gauges value type from int64 to uint64 #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VasilevNStas wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(pong)!: change gauges value type from int64 to uint64 #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pong.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ message Pong {
// Unknown keys must be ignored by the client. Max 32 entries;
// each key MUST NOT exceed 16 bytes. Clients MUST reject a Pong
// carrying a gauges map that violates these bounds.
map<string, int64> gauges = 16;
map<string, uint64> gauges = 16;

// Optional diagnostic line the Node wants surfaced to the user.
// Usually empty. When set, formatted as "X WWW": a single
Expand Down