fix(pong)!: change gauges value type from int64 to uint64#42
Open
VasilevNStas wants to merge 1 commit into
Open
fix(pong)!: change gauges value type from int64 to uint64#42VasilevNStas wants to merge 1 commit into
VasilevNStas wants to merge 1 commit into
Conversation
Contributor
Author
|
@davvd plz review |
Member
|
@VasilevNStas we have merge conflicts here, please resolve them and we'll merge |
All documented gauge values (SLA, clients, version, brothers, stalls, rtt, PPM, MEM) are inherently non-negative. Using int64 admits negative values that have no defined protocol meaning and no consumer can interpret. The sharpest inconsistency is the 'version' gauge, documented to mirror Welcome.minor (uint32), yet the wire type allowed -1. Change map<string, int64> to map<string, uint64>. This is a breaking wire change only for negative integers, which carry no semantic value and are never produced by the Node.
VasilevNStas
force-pushed
the
10-fix/gauges-uint64
branch
from
July 4, 2026 18:04
5ed3d41 to
8a88975
Compare
Contributor
Author
|
@davvd conflicts resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes the
gaugesvalue type fromint64touint64— all documented gauge values are non-negative.Problem
map<string, int64>admits negative values that have no defined meaning for any documented key:versionis documented as mirroringWelcome.minor(uint32), yet the wire type allowed-1Fix
map<string, uint64>— rules out semantically impossible negative values at the type level.Migration
Breaking only for negative integers, which are never produced by the Node and carry no semantics. All real values (≥ 0) are compatible without changes.
Closes #10