Skip to content

chore: tidy pom and silence build warnings #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
66-m merged 1 commit into from
Mar 11, 2026
Merged

chore: tidy pom and silence build warnings #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
</mainClass>
</manifest>
</archive>
<appendAssemblyId>false</appendAssemblyId>
<appendAssemblyId>true</appendAssemblyId>

Copilot AI Mar 11, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing maven-assembly-plugin to true will change the fat-jar output name from target/sorting-visualizer.jar to something like target/sorting-visualizer-jar-with-dependencies.jar, while the plain (non-dependency) jar remains target/sorting-visualizer.jar. The repo’s run script and README currently hard-code target/sorting-visualizer.jar as the runnable artifact, so this change will break those workflows unless they are updated (or the build is configured to keep producing a runnable jar at that path).

Suggested change
<appendAssemblyId>true</appendAssemblyId>
<appendAssemblyId>false</appendAssemblyId>

Copilot uses AI. Check for mistakes.
<descriptorRefs>
<descriptorRef>jar-with-dependencies</descriptorRef>
</descriptorRefs>
Expand All @@ -71,6 +71,20 @@
<groupId>com.github.66-m</groupId> <!-- micycle1 fork -->
<artifactId>processing-core-4</artifactId>
<version>41a134a448</version>
<exclusions>
<exclusion>
<groupId>org.openjfx</groupId>
<artifactId>javafx-controls</artifactId>
</exclusion>
<exclusion>
<groupId>org.openjfx</groupId>
<artifactId>javafx-graphics</artifactId>
</exclusion>
<exclusion>
<groupId>org.openjfx</groupId>
<artifactId>javafx-base</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>net.compartmental.code</groupId>
Expand Down
Loading