chore: tidy pom and silence build warnings#33
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Maven build configuration to reduce build noise and adjust dependency/packaging behavior.
Changes:
- Changes
maven-assembly-pluginoutput naming by enabling<appendAssemblyId>. - Excludes transitive JavaFX (
org.openjfx) dependencies fromprocessing-core-4.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| </manifest> | ||
| </archive> | ||
| <appendAssemblyId>false</appendAssemblyId> | ||
| <appendAssemblyId>true</appendAssemblyId> |
There was a problem hiding this comment.
Changing maven-assembly-plugin to true will change the fat-jar output name from target/sorting-visualizer.jar to something like target/sorting-visualizer-jar-with-dependencies.jar, while the plain (non-dependency) jar remains target/sorting-visualizer.jar. The repo’s run script and README currently hard-code target/sorting-visualizer.jar as the runnable artifact, so this change will break those workflows unless they are updated (or the build is configured to keep producing a runnable jar at that path).
| <appendAssemblyId>true</appendAssemblyId> | |
| <appendAssemblyId>false</appendAssemblyId> |
No description provided.