Document the invmon "float" field#99
Open
rodarvus wants to merge 1 commit into
Open
Conversation
Spellups["GL"]["float"] is updated by the invmon trigger handler but the variable name doesn't say what role it plays. Add a four-line comment above the function explaining that it remembers whatever non-aura item the user normally wears in the floating slot (loc 27) so OnPluginBroadcast can re-wear it after auto-aura swaps the aura in to cast sanctuary. Comment-only; no behavior change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Spellups["GL"]["float"]is updated by theinvmonhandler inSpellupRecast/Hadar_Spellups.xmland consumed byOnPluginBroadcastwhen auto-aura fires, but the variable name doesn't say what role it plays. This adds a four-line comment above the function describing the round-trip:invmonremembers whatever non-aura item the user normally wears in the floating slot (loc 27) so the broadcast handler can re-wear it after the aura swap ("wear "..Spellups["GL"]["float"]).Comment-only; no behavior change.
Before
After
Test plan
🤖 Generated with Claude Code