Clarify wraithform skip-branch comment in affoff#97
Open
rodarvus wants to merge 1 commit into
Open
Conversation
In affoff(), when wraithform (sn 180) drops, the loop over Spellups["EX"]["wraithform"] checks each related spell with table.find(v, Spellups["AF"]["list"]) -- a truthy result means spell v is currently affecting the player. In that case the branch intentionally does nothing (the spell is still active, no need to requeue); otherwise the spell is requeued. Replace the unclear "--left empty becaue" placeholder with a comment that says what the empty branch is for. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
SpellupRecast/Hadar_Spellups.xml, theaffoff()function has a loop that runs when wraithform (sn 180) drops. The loop iterates overSpellups["EX"]["wraithform"]and, for each related spell, checkstable.find(v, Spellups["AF"]["list"])— a truthy result means the player is currently affected by spellv. In that case the branch is intentionally a no-op (spell is still active, nothing to requeue); theelsebranch queues and recasts.The original placeholder comment was
--left empty becaue(typo, no explanation), which doesn't tell a reader why the branch is empty. This PR replaces it with a one-line comment describing the intent.Before
After
Test plan
🤖 Generated with Claude Code