Skip to content

Remove dead autoaura branch in sfail fl==6 handler#96

Open
rodarvus wants to merge 1 commit into
zzyzzyzzx:masterfrom
rodarvus:fix/remove-dead-autoaura-fl6-branch
Open

Remove dead autoaura branch in sfail fl==6 handler#96
rodarvus wants to merge 1 commit into
zzyzzyzzx:masterfrom
rodarvus:fix/remove-dead-autoaura-fl6-branch

Conversation

@rodarvus

Copy link
Copy Markdown

Summary

In SpellupRecast/Hadar_Spellups.xml, the sfail() function had a fl == 6 block containing a nested if Spellups["GL"]["autoaura"] == 1 then with an empty body and a --setup auto aura stuff here placeholder comment. The autoaura flag is stored and compared as the string "yes"/"no" everywhere else in the plugin (e.g. the autoaura == "yes" check in affoff), so the == 1 comparison could never succeed. The body was empty regardless, so the whole nested block was a no-op.

The actual fl == 6 handling lives in the next conditional, if fl == 1 or fl == 6 then, which is unchanged by this PR.

Before

if fl == 6 then
    if Spellups["GL"]["autoaura"] == 1 then
        --setup auto aura stuff here
    end
end

if fl == 1 or fl == 6 then
    ...
end

After

if fl == 1 or fl == 6 then
    ...
end

Test plan

  • Pure dead-code removal — empty branch, never-true comparison. No runtime behavior change to test.
  • Confirmed by grep that autoaura is compared as a string ("yes"/"no") everywhere else; no caller depends on the deleted block.

🤖 Generated with Claude Code

In sfail(), the fl==6 handler contained an inner check
"if Spellups['GL']['autoaura'] == 1 then" with an empty body and a
"--setup auto aura stuff here" placeholder comment. The autoaura flag
is stored and compared as the string "yes"/"no" everywhere else (e.g.
the autoaura==yes check just below in affoff), so the ==1 comparison
could never succeed; the body was empty in any case, making the entire
nested if-block a no-op.

The real fl==6 handling lives in the next conditional
"if fl == 1 or fl == 6 then", which is unaffected by this change.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant