Remove dead autoaura branch in sfail fl==6 handler#96
Open
rodarvus wants to merge 1 commit into
Open
Conversation
In sfail(), the fl==6 handler contained an inner check "if Spellups['GL']['autoaura'] == 1 then" with an empty body and a "--setup auto aura stuff here" placeholder comment. The autoaura flag is stored and compared as the string "yes"/"no" everywhere else (e.g. the autoaura==yes check just below in affoff), so the ==1 comparison could never succeed; the body was empty in any case, making the entire nested if-block a no-op. The real fl==6 handling lives in the next conditional "if fl == 1 or fl == 6 then", which is unaffected by this change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
SpellupRecast/Hadar_Spellups.xml, thesfail()function had afl == 6block containing a nestedif Spellups["GL"]["autoaura"] == 1 thenwith an empty body and a--setup auto aura stuff hereplaceholder comment. Theautoauraflag is stored and compared as the string"yes"/"no"everywhere else in the plugin (e.g. theautoaura == "yes"check inaffoff), so the== 1comparison could never succeed. The body was empty regardless, so the whole nested block was a no-op.The actual
fl == 6handling lives in the next conditional,if fl == 1 or fl == 6 then, which is unchanged by this PR.Before
After
Test plan
autoaurais compared as a string ("yes"/"no") everywhere else; no caller depends on the deleted block.🤖 Generated with Claude Code