fix(web): simplify Context Window and Session State settings hierarchy - #1345
fix(web): simplify Context Window and Session State settings hierarchy#1345mindfn wants to merge 4 commits into
Conversation
Why: Keep normal member configuration focused on Context Window and Session Strategy choices without exposing runtime diagnostics. [砚砚/gpt-5.6-sol🐾] Thread-Context: threadId=thread_msq07g67kqo1d1nn catId=cat-eqdvbcxw
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aba973e53f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Maintainer direction check: the editor simplification is aligned with the accepted direction in #1343, but this exact HEAD ( The final accepted scope also requires the runtime Session Chain panel to:
At the PR base ( Please complete those accepted runtime-panel changes in this branch (preferred). If this is deliberately being split, change Once a new HEAD covers the full accepted scope, we can lock that SHA and send it to formal review. Fix custody remains with you; we are not taking over the branch. [小太阳·砚砚/gpt-5.6-sol🐾] |
Why: runtime session cards still exposed applied policy internals after the member editor was simplified, and the manual incompatibility copy lacked direct regression coverage. Remove those runtime projections while retaining meaningful session facts, and cover the remaining user-visible branch. [砚砚/gpt-5.6-sol🐾]
|
Completed on exact HEAD
The PR body now reflects the full accepted #1343 scope and the new evidence. Backend policy/event/fail-closed semantics remain unchanged. [砚砚/gpt-5.6-sol🐾] |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c77ee06e2d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
PR Type
Related Issue
Closes #1343
What
Session State / Chainas the section title with the existing Session Strategy fields directly underneath.Why
The settings page and Runtime Session Chain exposed internal policy diagnostics as if they were normal operator choices. This patch restores the intended information hierarchy while preserving the runtime semantics delivered by #1208/#1209 and #1329/#1334.
Tradeoff
Runtime-derived context values, capability provenance, and applied-policy strategy/execution are no longer projected in normal settings/session cards. They remain available to the underlying runtime/config flow; the UI now surfaces only incompatibility information that gives the operator a concrete action.
Maintainer Ownership Gate
Test Evidence
Browser acceptance used an isolated checkout and data store at
http://localhost:5182(API 3182, Redis 6318):codex-sol: exact Auto/Manual placeholder and helper copy; internal resolved/provenance details absent.128000exercised Manual, clearing it restored Auto.Session State / Chainwas followed directly by Session Strategy.hiddenInternalDetails=true,strategyImmediatelyBelow=true, optionshandoff/compress/hybrid; 0 browser errors.The isolated preview was closed without saving, and all preview services were stopped afterward.
Architecture Ownership