Skip to content

fix: add Windows platform support for process group killing in ManagedRunner #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
whutzefengxie-ops wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: add Windows platform support for process group killing in ManagedRunner #1285

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94a600d
fix: add Windows platform support for process group killing in Manage…
whutzefengxie-ops Aug 4, 2026
e6fd426
Merge branch 'main' into fix/windows-process-group-kill
zts212653 Aug 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions packages/api/src/infrastructure/managed-runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* IDLE → RUNNING → {COMPLETED | TIMED_OUT | CANCELLED} → (log cleaned up)
*/

import { type ChildProcess, spawn } from 'node:child_process';
import { type ChildProcess, execFileSync, spawn } from 'node:child_process';
import { createWriteStream, existsSync, mkdirSync, readFileSync, unlinkSync } from 'node:fs';
import { tmpdir } from 'node:os';
import { join } from 'node:path';
Expand Down Expand Up @@ -294,14 +294,32 @@ export class ManagedRunner {
/**
* P1-2 fix: kill the entire process group (shell + child processes).
* With detached=true, child.pid IS the process group leader.
* process.kill(-pid, signal) sends the signal to all processes in the group.
*
* Platform-specific implementation:
* - Unix: process.kill(-pid, signal) sends signal to all processes in the group
* - Windows: taskkill /T kills the entire process tree
*/
private _killProcessGroup(signal: NodeJS.Signals): void {
if (!this._pid) return;

try {
process.kill(-this._pid, signal);
} catch {
if (process.platform === 'win32') {
// Windows: use taskkill /T to kill the entire process tree
// /T = terminate all child processes
// /F = force termination (only for SIGKILL equivalent)
const args = signal === 'SIGKILL'
? ['/PID', String(this._pid), '/T', '/F']
: ['/PID', String(this._pid), '/T'];
execFileSync('taskkill', args, { stdio: 'ignore' });
log.debug({ pid: this._pid, signal, args }, 'ManagedRunner: taskkill sent (Windows)');
} else {
// Unix: use negative PID to kill the process group
process.kill(-this._pid, signal);
log.debug({ pid: this._pid, signal }, 'ManagedRunner: signal sent to process group (Unix)');
}
} catch (err) {
// Process group may already be gone — that's fine
log.debug({ pid: this._pid, signal, err }, 'ManagedRunner: kill process group failed (may already be dead)');
}
}

Expand Down
Loading