Skip to content

fix(auth): 移除日志中AccessKey明文打印#15

Merged
zshs000 merged 2 commits into
zshs000:masterfrom
zhoujiaxin0428:fix/remove-accesskey-log
Jun 12, 2026
Merged

fix(auth): 移除日志中AccessKey明文打印#15
zshs000 merged 2 commits into
zshs000:masterfrom
zhoujiaxin0428:fix/remove-accesskey-log

Conversation

@zhoujiaxin0428

@zhoujiaxin0428 zhoujiaxin0428 commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

修复

删除敏感信息日志输出,改为打印初始化成功信息
为了关闭#13

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes sensitive credential logging (AccessKeyId and AccessKeySecret) during the initialization of the Aliyun SMS client, replacing it with a success log. The reviewer rightly pointed out that logging success before the client is successfully instantiated is misleading if an exception occurs, and provided a code suggestion to log only after successful instantiation.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread eaqb-auth/src/main/java/com/zhoushuo/eaqb/auth/sms/AliyunSmsClientConfig.java Outdated
@zhoujiaxin0428

Copy link
Copy Markdown
Contributor Author

@zshs000 我已经修复了,请你cr一下

@zshs000

zshs000 commented Jun 12, 2026

Copy link
Copy Markdown
Owner

@zhoujiaxin0428 lgtm

@zshs000
zshs000 merged commit 46a9bd3 into zshs000:master Jun 12, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants