Skip to content

fix(auth): 移除日志中AccessKeySecret明文打印 #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhoujiaxin0428 wants to merge 1 commit into from
Closed

fix(auth): 移除日志中AccessKeySecret明文打印 #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions eaqb-auth/src/main/java/com/zhoushuo/eaqb/auth/sms/AliyunSmsClientConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,7 @@ public com.aliyun.dypnsapi20170525.Client smsClient() {
config.accessKeyId = aliyunAccessKeyProperties.getAccessKeyId(); // 必填
config.accessKeySecret = aliyunAccessKeyProperties.getAccessKeySecret(); // 必填

// 添加日志输出（注意：生产环境中不要打印密钥信息）
log.info("AccessKeyId: {}", config.accessKeyId);
log.info("AccessKeySecret: {}", config.accessKeySecret);
log.info("阿里云短信客户端初始化成功");

return new com.aliyun.dypnsapi20170525.Client(config);
Comment on lines +30 to 32

@gemini-code-assist gemini-code-assist Bot Jun 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

当前日志“阿里云短信客户端初始化成功”在创建 Client 实例之前打印。由于 new com.aliyun.dypnsapi20170525.Client(config) 可能会抛出异常并被 catch 块捕获，如果在实例化时发生异常，日志中仍会先输出“初始化成功”的信息，随后又输出错误日志，这会产生误导。建议在成功创建 Client 实例后再打印成功日志。

Suggested change
log.info("阿里云短信客户端初始化成功");
return new com.aliyun.dypnsapi20170525.Client(config);
com.aliyun.dypnsapi20170525.Client client = new com.aliyun.dypnsapi20170525.Client(config);
log.info("阿里云短信客户端初始化成功");
return client;

} catch (Exception e) {
Expand Down
Loading