Skip to content

feat: add ? help hint and missing keys to all mode footers#37

Merged
zpenka merged 3 commits into
mainfrom
feat/footer-completeness
May 8, 2026
Merged

feat: add ? help hint and missing keys to all mode footers#37
zpenka merged 3 commits into
mainfrom
feat/footer-completeness

Conversation

@zpenka
Copy link
Copy Markdown
Owner

@zpenka zpenka commented May 8, 2026

Every mode footer was missing the ? help hint, making the help overlay undiscoverable without already knowing the key. List and detail footers were also missing keys that are present in the help overlay.

Changes

All footers now show ? help. Additional fixes per mode:

Mode Added
List m bookmark, M bookmarks, T timeline, ? help; shortened p filter projectp project, b filter branchb branch, S usage statsS stats
Detail m bookmark, / search, ? help
Search results ? help
Stats ? help
Project ? help
Rerun ? help
Timeline ? help

Commits

  • Red commit: bd353d0 — failing tests for all missing hints
  • Green commit: 07bc4aa — footer updates + stale test assertions fixed

Test plan

  • go test -race ./... — all pass
  • go vet ./... — clean
  • gofmt -l . — clean

Zack Penka and others added 3 commits May 8, 2026 10:46
Tests verify:
- Every mode footer shows "?" so users can discover the help overlay.
- List footer shows "m bookmark", "M bookmarks", "T timeline".
- Detail footer shows "m bookmark" and "/ search".

All 10 new assertions currently fail.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Every footer now shows "? help" so users can discover the help overlay.
List footer gains "m bookmark", "M bookmarks", "T timeline" and shortens
"p filter project" -> "p project", "b filter branch" -> "b branch",
"S usage stats" -> "S stats". Detail footer gains "m bookmark" and
"/ search". All other mode footers gain "? help".

Also updates the stale assertions in TestRenderFooter_DefaultFooter to
match the new shorter labels.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
CLAUDE.md Rendering & View section now states that every footer includes
"? help" alongside the existing back-nav / quit conventions.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@zpenka zpenka force-pushed the feat/footer-completeness branch from 07bc4aa to d4decf0 Compare May 8, 2026 16:47
@zpenka zpenka merged commit 6cbe66e into main May 8, 2026
1 check passed
@zpenka zpenka deleted the feat/footer-completeness branch May 8, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant