Skip to content

Code Cleanup: Attempt 1#234

Closed
sakshibobade21 wants to merge 4 commits into
v2.x/stagingfrom
code-cleanup
Closed

Code Cleanup: Attempt 1#234
sakshibobade21 wants to merge 4 commits into
v2.x/stagingfrom
code-cleanup

Conversation

@sakshibobade21

Copy link
Copy Markdown
Contributor

Proposed changes

This PR addresses Issue: [Link to Github issue within https://github.com/zowe/zen/issues if any]

This PR depends upon the following PRs:

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Change in a documentation
  • Refactor the code
  • Chore, repository cleanup, updates the dependencies.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

PR Checklist

Please delete options that are not relevant.

  • If the changes in this PR are meant for the next release / mainline, this PR targets a "staging" branch.
  • My code follows the style guidelines of this project (see: Contributing guideline)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
  • video or image is included if visual changes are made
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works, or describe a test method below

Testing

Further comments

Signed-off-by: Sakshi Bobade <bobadesakshi21@gmail.com>
Signed-off-by: Sakshi Bobade <bobadesakshi21@gmail.com>
@skurnevich

Copy link
Copy Markdown
Collaborator

Isn't this duplicate of changes made in PR 231?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

2 participants