Use SDT for Reading Mode and Read Aloud#204
Draft
AbeJellinek wants to merge 15 commits into
Draft
Conversation
And extract mixin for spinner
- Entirely missing in PDF (we weren't passing pageIndex, and then it was moving away due to the cursor matching a different block) - Basically nonfunctional in EPUB/snapshot (block-segment map became stale) - Wrong-granularity optimistic highlight
Fixes two highlighting failures that produced "Unable to get range for
CFI" log spam and missing highlights:
- Pass deltaMaps to resolveSelectorMapRange in the cross-path branch so
NFC-space offsets get translated to original DOM offsets
- Return null from _getExpandedPath when an entry has no text-node
anchor (e.g., synthetic image alt-text entries). The previous fallback
to blockAnchor.selectorMap targeted the image element step
(".../16/2"), and appending character offsets to an element step
produced unresolvable CFIs like "epubcfi(.../16/2,:0,:16)".
And update SDT submodule
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.