Added S3 inventory to storage purge#54
Open
mrtcode wants to merge 1 commit into
Open
Conversation
mrtcode
commented
May 25, 2017
| $info->filename = $key; | ||
| //$info->zip = ?; | ||
|
|
||
| $info = Zotero_Storage::getLocalFileInfo($info); |
Member
Author
There was a problem hiding this comment.
There is a short window between getting file info and deleting it, where it can be updated by other user and result in a missing S3 file. One option would be to move this code in transaction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that the current purge scripts are quite old. There are some incompatibilities. For example getLocalFileInfo($info) function wants 'zip' paprameter, but we don't have it, because all file names are just hashes. So it means we need a modified getLocalFileInfo function that doesn't use 'zip' parameter in query?
There was a 'TODO' mentioning to use SSCAN when it will be available in phpredis. Now phpredis supports getting multiple results with spop. What was the initial behind SSCAN? performance?