Skip to content

Remove obsolete setuptools runtime dependency#130

Merged
icemac merged 1 commit into
zopefoundation:masterfrom
mgorny:setuptools-dep
Sep 15, 2025
Merged

Remove obsolete setuptools runtime dependency#130
icemac merged 1 commit into
zopefoundation:masterfrom
mgorny:setuptools-dep

Conversation

@mgorny

@mgorny mgorny commented Sep 13, 2025

Copy link
Copy Markdown
Contributor

The runtime dependency on setuptools was only required for namespace support. Since pkg_resources-style namespaces have been removed in #52 and there are no relevant imports left in the code, remove the unnecessary dependency.

  • I signed and returned the Zope Contributor Agreement, and received and accepted an invitation to join a team in the zopefoundation GitHub organization.
  • I verified there aren't any other open pull requests for the same change.
  • I followed the guidelines in Developer guidelines.
  • I successfully ran code quality checks on my changes locally.
  • I successfully ran tests on my changes locally.
  • If needed, I added new tests for my changes.
  • If needed, I added documentation for my changes.
  • I included a change log entry in my commits.

The runtime dependency on `setuptools` was only required for namespace
support.  Since `pkg_resources`-style namespaces have been removed
in zopefoundation#52 and there are no relevant imports left in the code, remove
the unnecessary dependency.

Signed-off-by: Michał Górny <mgorny@gentoo.org>
@mgorny

mgorny commented Sep 13, 2025

Copy link
Copy Markdown
Contributor Author

@icemac, I see the same problem applies to other packages released yesterday. Should I open separate PRs for all of them, or could you perhaps handle it en masse?

@icemac icemac enabled auto-merge (squash) September 15, 2025 06:55
@icemac

icemac commented Sep 15, 2025

Copy link
Copy Markdown
Member

@mgorny Thank you for the PR. My idea was to solve this issue more generally via zopefoundation/meta#345 – but it can take some time until I'll be able to tackle it. So I'd appreciate individual PRs for the repositories where the setuptools dependency bothers you.

@icemac icemac merged commit 11e3f0b into zopefoundation:master Sep 15, 2025
10 checks passed
@mgorny mgorny deleted the setuptools-dep branch September 15, 2025 11:13
@mgorny

mgorny commented Sep 15, 2025

Copy link
Copy Markdown
Contributor Author

Thanks, I'll do that when I have some time.

@cjwatson

Copy link
Copy Markdown
Contributor

@mgorny I've filed a bunch of individual PRs for this, but just for zope.* packages that are in Debian.

@mgorny

mgorny commented Sep 21, 2025

Copy link
Copy Markdown
Contributor Author

Thanks! I'm sorry for not being able to look at it sooner.

@mgorny

mgorny commented Sep 21, 2025

Copy link
Copy Markdown
Contributor Author

Okay, I've filed PRs for the two extra packages that we had, and that should cover them all. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants