fix: capture gateway IP for hop 2 failures when traceroute times out - #18
Merged
Merged
Conversation
When ISP issue is diagnosed at hop 2 because gateway was reachable but traceroute completely timed out (all * * *), identify_failing_hop() returned None since there were no responding hops. The gateway IP fallback was only implemented for Healthy and Unknown cases. Now uses gateway IP as last responding hop when identify_failing_hop() returns None for IspIssue at hop 2 with a reachable gateway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
failing_hop_ipnot being captured for ISP issues at hop 2 when traceroute times outChanges
src/main.rs: Added fallback to use gateway IP whenidentify_failing_hop()returnsNoneforIspIssueat hop 2Test Plan
Hop 2 (after 10.0.0.1) - ISP Modeminstead of justHop 2 (ISP Modem)