chore: /lfg PR body must use closing keywords to auto-close issues - #16
Merged
Conversation
The Phase 7 template wrote `Refs #N` in commits, which links but never auto-closes an issue on merge. Five issues (#9-#13) stayed open after their PRs merged and had to be closed by hand. Require a GitHub closing keyword (Closes/Fixes/Resolves #N, one per issue) in the PR BODY — the reliable place, since a keyword in a squashed commit can be lost. Document the multi-issue form (repeat the keyword) and a gh issue close fallback, and allowlist `gh issue close` for that fallback.
mhenrixon
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
/lfgPhase 7 template told the workflow to writeRefs #Nin commitmessages.
Refslinks an issue but never closes it — so #9–#13 allstayed open after their PRs (#14, #15) merged, and had to be closed by hand.
What changed
.claude/commands/lfg.md:Closes #N/Fixes #N/Resolves #N) for every resolved issue, in the Summary — the reliable place,because a keyword living only in a commit body can be dropped on squash-merge.
Closes #9, closes #10—Closes #9, #10only closes Feature: a checkbox-group builder verb for array-valued associations #9).gh issue closefallback for when a PR merges without the keyword, andallowlisted
gh issue closein the frontmatter so the fallback doesn't prompt.Test plan
Docs/instruction-only change — no code. Verified the keyword rules against
GitHub's linked-PR behavior (only Close/Fix/Resolve keywords auto-close; one
keyword per issue number).