Skip to content

Display an error when trying to add an user with a non-localhost IP #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
3 commits merged into from Oct 13, 2021
Merged

Display an error when trying to add an user with a non-localhost IP #889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d85afa6
Raise an error if method called from remote IP
Oct 12, 2021
dd83a68
Update documentation with example output
Oct 12, 2021
b03c859
Improve error wording
Oct 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions docs/API.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1208,9 +1208,15 @@ Omitting params:
Trying to add a user over non-localhost:
```json
{
"result": 0,
"id": 1,
"jsonrpc": "2.0"
"jsonrpc": "2.0",
"error": {
"code": -32603,
"data": {
"remote_ip": "10.0.0.1"
},
"message": "Call to \"add_api_user\" method not permitted from a remote IP"
}
}
```

Expand Down
6 changes: 6 additions & 0 deletions lib/Zonemaster/Backend/RPCAPI.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,6 +575,12 @@ sub add_api_user {
if ( $allow ) {
$result = 1 if ( $self->{db}->add_api_user( $params->{username}, $params->{api_key} ) eq '1' );
}
else {
die Zonemaster::Backend::Error::PermissionDenied->new(
message => 'Call to "add_api_user" method not permitted from a remote IP',
data => { remote_ip => $remote_ip }
);
}
};
if ($@) {
handle_exception( $@ );
Expand Down