Skip to content

fix: try adding the website to harden runnner#755

Closed
Its-Just-Nans wants to merge 1 commit into
masterfrom
fix-deps
Closed

fix: try adding the website to harden runnner#755
Its-Just-Nans wants to merge 1 commit into
masterfrom
fix-deps

Conversation

@Its-Just-Nans
Copy link
Copy Markdown
Member

Trying to fix the #754 (comment)

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

Copy link
Copy Markdown
Contributor

@amazon-q-developer amazon-q-developer Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR correctly adds the api.deps.dev:443 endpoint to the allowed list for the harden-runner in the dependency_review job, which should fix the connectivity issue referenced in the PR description.

However, the PR title contains a typo: "runnner" should be "runner". Please update the title to: fix: try adding the website to harden runner


You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

@Its-Just-Nans
Copy link
Copy Markdown
Member Author

@Pr0methean @im7mortal

That's strange, the dependency review is working is this MR
https://github.com/zip-rs/zip2/actions/runs/23696002687/job/69031281824?pr=755

with

Run actions/dependency-review-action@2031cfc080254a8a887f58cffee85186f0e49e48
No snapshots were found for the head SHA cc9d68da948250f766bc67246a7c89ad920375a5.
Vulnerabilities
Licenses
Denied
Scorecard
Dependency Changes

But not on the MR of #754

Run actions/dependency-review-action@2031cfc080254a8a887f58cffee85186f0e49e48
  with:
    repo-token: ***
  env:
    RUSTFLAGS: -Dwarnings
    MACOSX_DEPLOYMENT_TARGET: 14.5
No snapshots were found for the head SHA 199a6680b8eea1db63b0f060face48b1aed9cf1c.
Error: fetch failed

Not sure if this MR really fixes the runner

@Its-Just-Nans
Copy link
Copy Markdown
Member Author

Closing in favor of #756

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant