feat: add soft-reference compile-time caches#588
Open
ningyang1988 wants to merge 1 commit into
Open
Conversation
Author
|
CLA assistant shows that the agreement has already been accepted on my side ('You have agreed to the CLA for zio/izumi-reflect'), but the PR check is still pending as not signed. I also retriggered the recheck link while logged into the same GitHub account that opened this PR. Could you please help re-sync or re-run the CLA check? Thanks! |
48ec1e0 to
46920a8
Compare
Author
|
Gentle bump — checking if there is anything I can do to help move this PR forward. Happy to address any feedback. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the soft-reference compile-time cache requested in #350 with a small, targeted patch.
What changed
ref,fullDb, andinheritanceDbwithSoftReferenceTypeInspectionsValidation
-Dizumi.reflect.rtti.cache.compile=falsestill passes TagTestsbt +clean +testpassed (209 tests, 0 failed)Notes
Closes #350