This repository was archived by the owner on Jan 13, 2025. It is now read-only.
Add a channel that outputs to a subscriber. - #360
Open
quelgar wants to merge 4 commits into
Open
Conversation
Using a channel to drive a subscriber instead of a sink has the advantage that we can pass upstream errors through to the subscriber's `onError` method without needing the caller to manually install an error handler. While a channel is not as convenient to use as a sink, it is more convenient that the error handler + sink pair.
quelgar
force-pushed
the
channel-to-subscriber
branch
from
April 21, 2023 00:35
c2f1a9c to
83e0f63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal to replace the current
subscriber.toZIOSinkwith a channel. The advantage of a channel is that it is notified of upstream errors and can propagate them to the subscriber'sonErrormethod. While a channel is generally not as convenient to use as a sink, I think it is more convenient than the current sink + error handler pairing, asScopeto be exposed to the callerSo this:
becomes:
For the API, I've followed the
ZChannelconvention instead of the existing style. ForZChannelthe way "to" and "from" are used is different. For example, there'sZSink.fromQueuewhich means "create a sink from this queue", whereas the channel equivalent isZChannel.toQueuewhich means "create a channel that outputs to this queue". We could definitely dosubscriber.toZIOChannelinstead or in addition though.Edit: I just changed it to propagate upstream errors in addition to signalling
onErrorto the subscriber. Seems desirable? So the output error isSome(throwable)for an upstream error andNonefor cancellation by the subscriber.