Skip to content

fix paramFirstToken on variadic function #3207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Techatrix merged 1 commit into from
May 24, 2026
+13 −1
Merged

fix paramFirstToken on variadic function #3207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/ast.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -859,7 +859,10 @@ pub fn paramFirstToken(tree: *const Ast, param: Ast.full.FnProto.Param, include_
return (if (include_doc_comment) param.first_doc_comment else null) orelse
param.comptime_noalias orelse
param.name_token orelse
tree.firstToken(param.type_expr.?);
if (param.type_expr) |te|
tree.firstToken(te)
else
param.anytype_ellipsis3.?;
}

pub fn paramLastToken(tree: *const Ast, param: Ast.full.FnProto.Param) Ast.TokenIndex {
Expand Down
9 changes: 9 additions & 0 deletions tests/lsp_features/selection_range.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,15 @@ test "between nodes" {
, &.{});
}

test "variadic function" {
try testSelectionRange(
\\fn foo(...<>) void {}
, &.{
"...",
"fn foo(...) void",
});
}

test "expression inside function" {
try testSelectionRange(
\\fn main() void {
Expand Down
Loading